Update to psalm 5 #37390
Merged
Update to psalm 5 #37390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
force-pushed
the
update/psalm-5
branch
from
6b88d85
to
47e897d
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
provokateurin
force-pushed
the
update/psalm-5
branch
2 times, most recently
from
0da5bdd
to
f752b68
Compare
| */ | ||
| public function setAvailability($available) { | ||
| public function setAvailability($isAvailable) { |
Check notice
Code scanning / Psalm
MissingReturnType
apps/user_ldap/lib/Access.php
Outdated
| @@ -354,7 +354,7 @@ | |||
| return @$this->invokeLDAPMethod('exopPasswd', $userDN, '', $password) || | |||
| @$this->invokeLDAPMethod('modReplace', $userDN, $password); | |||
| } catch (ConstraintViolationException $e) { | |||
| throw new HintException('Password change rejected.', \OC::$server->getL10N('user_ldap')->t('Password change rejected. Hint: ') . $e->getMessage(), (int)$e->getCode()); | |||
| throw new HintException('Password change rejected.', \OC::$server->getL10N('user_ldap')->t('Password change rejected. Hint: ') . $e->getMessage(), $e->getCode()); | |||
Check notice
Code scanning / Psalm
DeprecatedMethod
provokateurin
force-pushed
the
update/psalm-5
branch
from
f752b68
to
4adfc63
Compare
provokateurin
force-pushed
the
update/psalm-5
branch
4 times, most recently
from
9bc45e9
to
c7ec317
Compare
| @@ -99,7 +99,7 @@ | |||
|
|
|||
| // Create a new job and store the creation date | |||
| $this->jobList->add(ResetTokenBackgroundJob::class); | |||
| $this->config->setAppValue('core', 'updater.secret.created', $this->timeFactory->getTime()); | |||
| $this->config->setAppValue('core', 'updater.secret.created', (string)$this->timeFactory->getTime()); | |||
Check notice
Code scanning / Psalm
DeprecatedMethod
provokateurin
force-pushed
the
update/psalm-5
branch
from
c7ec317
to
3f969f7
Compare
provokateurin
force-pushed
the
update/psalm-5
branch
3 times, most recently
from
d634595
to
0be733b
Compare
provokateurin
requested review from
ChristophWurst,
miaulalala,
nickvergessen and
tcitworld
as code owners
provokateurin
requested review from
come-nc,
nickvergessen,
miaulalala and
ChristophWurst
and removed request for
nickvergessen,
ChristophWurst,
tcitworld and
miaulalala
This was referenced Mar 31, 2023
Closed
Merged
4 tasks
This was referenced Apr 14, 2023
provokateurin
force-pushed
the
update/psalm-5
branch
from
0be733b
to
c2a289e
Compare
|
I already tried fixing a lot of the new found issues, but it's getting out of hand. What I did now is just ignore all the new errors so that we can finally have psalm 5. |
|
No idea what the failing security analysis means, the output by psalm seems to be incorrect. |
|
Haha ;) An error on line 0 is not allowed 🤣 |
|
Yeah I filed an issue at vimeo/psalm#9712, I hope it gets fixed soon. |
come-nc
reviewed
Apr 25, 2023
come-nc
approved these changes
Apr 27, 2023
Signed-off-by: jld3103 <[email protected]>
provokateurin
force-pushed
the
update/psalm-5
branch
from
c2a289e
to
9fddbea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist